fix #17922: enable auto advance with long-press#20335
Open
Ayush-Patel-56 wants to merge 1 commit intoankidroid:mainfrom
Open
fix #17922: enable auto advance with long-press#20335Ayush-Patel-56 wants to merge 1 commit intoankidroid:mainfrom
Ayush-Patel-56 wants to merge 1 commit intoankidroid:mainfrom
Conversation
always set onclicklistener to support performclick().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Auto Advance stops working when "Show answer long-press time" is set to anything other than 0 in Accessibility settings.
Fixes
Approach
When long-press time is enabled, the show-answer button was only getting an
OnTouchListener— theOnClickListenerwas skipped entirely. Auto Advance triggers the button via performClick(), which only fires theOnClickListener, so it silently did nothing.The fix is straightforward: always set the
OnClickListener. When long-press is also enabled, theOnTouchListenerintercepts manual touches (returningtrueto consume them), while performClick() still works through the click listener as expected.How Has This Been Tested?
Tested manually on an emulator (API 30):
Checklist