fix: enable Windows CI build after socket porting#9
Merged
anonymoussoft merged 2 commits intomasterfrom Apr 1, 2026
Merged
Conversation
- Update tim2tox submodule to include IrcClientManager Winsock2 porting and ws2_32 link dependency - Remove continue-on-error from Windows CI job now that the build compiles - Improve build_tim2tox.sh with ARM64 arch support, pkg-config PATH setup, and powershell PATH for vcpkg post-build steps Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
- Update tim2tox submodule with Windows/MSVC porting for all source files: IrcClientManager Winsock2, uuid/unistd.h guards, std::filesystem for S_ISREG, sqlite3 guards, Windows macro undef, chrono include - Remove continue-on-error from Windows CI job - Improve build_tim2tox.sh with ARM64 arch support and vcpkg PATH setup Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IrcClientManager.cppWinsock2 porting (POSIX socket API → Windows-compatible abstractions)continue-on-error: truefrom the Windows CI job now that the native library compiles on MSVCbuild_tim2tox.shwith ARM64 architecture support and PATH setup for vcpkg toolsContext
Follow-up to PR #8. The Windows build was failing because
IrcClientManager.cppused POSIX socket APIs (close(),fcntl(),errno,sys/socket.h, etc.) that don't exist on Windows. These have been replaced with cross-platform macros (IRC_CLOSE_SOCKET,IRC_ERRNO,irc_set_nonblocking) that use Winsock2 on Windows.The native library (
tim2tox_ffi.dll) has been successfully built and verified on a Windows VM with MSVC.Test plan
continue-on-error)🤖 Generated with Claude Code