Issue #181 investigation: Referenced code does not exist in repository

[Copilot]

Issue anotheria/baldur-core#1228 requests refactoring net.anotheria.baldur.business.friend.FriendsService and related classes (FriendsPO, FriendsBO, FriendsPersistenceService) to use modern naming conventions and Spring Data Repository.

Findings

Code does not exist:

• No FriendsService, FriendsPO, FriendsBO, or FriendsPersistenceService found in repository
• No net.anotheria.baldur package exists
• Searched entire codebase and git history with no matches

Architecture mismatch:

• Issue requires Spring Data Repository
• Project uses custom in-memory repository pattern (no Spring framework dependency)
• Existing persistence follows patterns like InMemoryHistoryService and ComponentRepository

Conclusion

Cannot refactor non-existent code. Issue appears to be:

• Filed in wrong repository, or
• References removed/planned code

No changes made. Issue requires clarification or closure.

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Refactor net.anotheria.baldur.business.friend.FriendsService</issue_title>
<issue_description>Refactor friends service.

• FriendsPO should be named FriendEntity
• FriendsBO should be named Friend
• FriendsPersistenceServiceImpl and FriendsPersistenceService should be replaced with Spring Data Repository
• NamedQuery in FriendsPO should be replaced by repository methods.
• </issue_description>

Comments on the Issue (you are @copilot in this section)

• Fixes anotheria/baldur-core#1228

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[dvayanu]

@copilot check net.anotheria.baldur.business.friend in module biz.
net.anotheria.baldur.business.friend.FriendsService
net.anotheria.baldur.business.friend.persistance.FriendsPersistenceService
net.anotheria.baldur.business.friend.FriendsBO
net.anotheria.baldur.business.friend.persistance.FriendsPO

additional requirement: FriendsService parameter ownerId, targetId, accountId should be of type AccountId. Repository methods and Entity object should keep string attributes.