Open
Conversation
Author
|
I'd need some help from you. I didn't write tests for my changes, nor have I run any existing ones. Could you do that? Also, I need your opinion on the Android SDK < 28 implementation - alternatively, the separator could be completely ignored in this case. Personally, I think Android 5 (SDK 21) is quite old now, and should be removed. What do you think? |
Owner
|
Hi @d2dyno1 thanks for your contribution! I do not have the availability to look into this in the coming weeks as I'm in the process of moving. I approved tests to run in CI. |
Author
|
Looks like the build failed with missing workloads: Error: C:\Program Files\dotnet\sdk\10.0.102\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To build this project, the following workloads must be installed: maui-tizen [D:\a\ContextMenuContainer\ContextMenuContainer\src\APES.MAUI.csproj::TargetFramework=net10.0]
Error: C:\Program Files\dotnet\sdk\10.0.102\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.ImportWorkloads.targets(38,5): error NETSDK1147: To install these workloads, run the following command: dotnet workload restore [D:\a\ContextMenuContainer\ContextMenuContainer\src\APES.MAUI.csproj::TargetFramework=net10.0]I'm leaving it as it is now. Besides the tests and this error, the PR looks ready to merge. Please give it a check when you're free again 🙂 |
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds context menu separators on all platforms.
!= nulland== nulltois not nullandis nullnew UIImage(contextItem.Icon.File)toUIImage.FromBundle(contextItem.Icon.File)iOS
MacOS
Android
SDK >= 28

SDK < 28

Windows
No screenshots. The code should be working anyway.