Skip to content

Add the ability for the next_url during pagination to be fully qualified (like pulp api returns for example) - #148

Open
lennysh wants to merge 2 commits into
ansible:develfrom
lennysh:add-pagination-support-for-fully-qualified-next-urls
Open

Add the ability for the next_url during pagination to be fully qualified (like pulp api returns for example)#148
lennysh wants to merge 2 commits into
ansible:develfrom
lennysh:add-pagination-support-for-fully-qualified-next-urls

Conversation

@lennysh

@lennysh lennysh commented Mar 25, 2026

Copy link
Copy Markdown

Description

  • What is being changed?
    • This add's the ability to support the next_url value ALREADY being fully qualified.
  • Why is this change needed?
    • The Pulp API's next_url value is fully qualified unlike Controller's.
  • How does this change address the issue?
    • It add's a check to see if it's already fully qualified or not, and handles the result accordingly.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Test update
  • Refactoring (no functional changes)
  • Development environment change
  • Configuration change

Self-Review Checklist

  • I have performed a self-review of my code
  • I have added relevant comments to complex code sections
  • I have updated documentation where needed
  • I have considered the security impact of these changes
  • I have considered performance implications
  • I have thought about error handling and edge cases
  • I have tested the changes in my local environment

Testing Instructions

Prerequisites

Steps to Test

  1. Export hub_collections (or any Hub object) when the object count is over the MAX.

Expected Results

  • It should dump everything requested instead of giving a 404 error because it pre-pended the provided API endpoint path to the FRONT of the next_url value.

Additional Context

Required Actions

  • Requires documentation updates
  • Requires downstream repository changes
  • Requires infrastructure/deployment changes
  • Requires coordination with other teams
  • Blocked by PR/MR: #XXX

Screenshots/Logs

… /api/galaxy/pulp/api/v3/ansible/collections)
@lennysh
lennysh marked this pull request as ready for review March 25, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant