Skip to content

feat: add quadratic face rendering#1220

Open
waltersma wants to merge 11 commits intomainfrom
feat/quadratic-face-rendering
Open

feat: add quadratic face rendering#1220
waltersma wants to merge 11 commits intomainfrom
feat/quadratic-face-rendering

Conversation

@waltersma
Copy link
Contributor

@waltersma waltersma commented Jan 30, 2026

Description

Rendering fixes #106 for quadratic faces and non planar polgons.

Original:

image

Fix:

image

@github-actions github-actions bot added the enhancement New features or code improvements label Jan 30, 2026
@waltersma waltersma requested a review from Copilot January 30, 2026 12:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds improved rendering capabilities for non-planar polygon faces, particularly targeting quadratic elements with curved edges. The implementation subdivides faces through triangulation while preserving original mesh edges to prevent faceted appearance.

Changes:

  • Added improved_surface_rendering parameter to control rendering mode for non-planar surfaces
  • Implemented surface triangulation with original edge preservation in mesh processing
  • Updated rendering logic to display subdivided surfaces with separate edge rendering

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
src/ansys/meshing/prime/graphics/plotter.py Added improved_surface_rendering parameter and conditional rendering logic for subdivided faces with edge preservation
src/ansys/meshing/prime/core/mesh.py Implemented triangulation of polygon surfaces while storing original edges for accurate rendering
doc/changelog.d/1220.miscellaneous.md Added changelog entry for the new feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@waltersma waltersma requested a review from Copilot January 30, 2026 13:44
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

waltersma and others added 2 commits January 30, 2026 13:46
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@waltersma waltersma requested a review from Copilot January 30, 2026 13:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

waltersma and others added 2 commits January 30, 2026 13:50
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@waltersma waltersma marked this pull request as ready for review January 30, 2026 15:01
Copy link
Contributor

@AlejandroFernandezLuces AlejandroFernandezLuces left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a question about the design.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quadratic tet element display graphics issue

4 participants