Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds improved rendering capabilities for non-planar polygon faces, particularly targeting quadratic elements with curved edges. The implementation subdivides faces through triangulation while preserving original mesh edges to prevent faceted appearance.
Changes:
- Added
improved_surface_renderingparameter to control rendering mode for non-planar surfaces - Implemented surface triangulation with original edge preservation in mesh processing
- Updated rendering logic to display subdivided surfaces with separate edge rendering
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/ansys/meshing/prime/graphics/plotter.py | Added improved_surface_rendering parameter and conditional rendering logic for subdivided faces with edge preservation |
| src/ansys/meshing/prime/core/mesh.py | Implemented triangulation of polygon surfaces while storing original edges for accurate rendering |
| doc/changelog.d/1220.miscellaneous.md | Added changelog entry for the new feature |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
AlejandroFernandezLuces
left a comment
There was a problem hiding this comment.
LGTM, just a question about the design.
Description
Rendering fixes #106 for quadratic faces and non planar polgons.
Original:
Fix: