Skip to content

test: Add test for from_geometry#1228

Open
AlejandroFernandezLuces wants to merge 11 commits intomainfrom
test/add-test-from-geom
Open

test: Add test for from_geometry#1228
AlejandroFernandezLuces wants to merge 11 commits intomainfrom
test/add-test-from-geom

Conversation

@AlejandroFernandezLuces
Copy link
Contributor

Description

Please provide a brief description of the changes made in this pull request.

Issue linked

Please mention the issue number or describe the problem this pull request addresses.

Checklist

  • I have tested my changes locally.
  • I have added necessary documentation or updated existing documentation.
  • I have followed the coding style guidelines of this project.
  • I have added appropriate unit tests.
  • I have reviewed my changes before submitting this pull request.
  • I have linked the issue or issues that are solved to the PR if any.
  • I have assigned this PR to myself.
  • I have made sure that the title of my PR follows Conventional commits style (e.g. feat: wrap with feature edges)

@github-actions github-actions bot added maintenance Package and maintenance related testing Anything related to testing labels Feb 25, 2026
@github-actions github-actions bot added testing Anything related to testing and removed testing Anything related to testing labels Feb 25, 2026
@github-actions github-actions bot added testing Anything related to testing and removed testing Anything related to testing labels Feb 25, 2026
@github-actions github-actions bot added testing Anything related to testing and removed testing Anything related to testing labels Feb 26, 2026
@github-actions github-actions bot added testing Anything related to testing and removed testing Anything related to testing labels Feb 26, 2026
@github-actions github-actions bot added testing Anything related to testing and removed testing Anything related to testing labels Feb 26, 2026
@AlejandroFernandezLuces AlejandroFernandezLuces marked this pull request as ready for review February 26, 2026 12:56
@AlejandroFernandezLuces
Copy link
Contributor Author

Merge first #1181 , I will adapt later.

@github-actions github-actions bot added testing Anything related to testing and removed testing Anything related to testing labels Feb 27, 2026
Copy link
Contributor

@waltersma waltersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @AlejandroFernandezLuces , please can you ensure these are skipped if not run on the CICD to avoid the example in docs and tests. Thanks

(Cc @subhnayak , @rchopade7 )

@github-actions github-actions bot removed the testing Anything related to testing label Mar 3, 2026
@github-actions github-actions bot added the testing Anything related to testing label Mar 3, 2026
@github-actions github-actions bot added testing Anything related to testing and removed testing Anything related to testing labels Mar 3, 2026
@AlejandroFernandezLuces
Copy link
Contributor Author

I just added a skip mark for the test. The example is all commented out, so it shouldn't be running any code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Package and maintenance related testing Anything related to testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants