Open
Conversation
Fix the bug in Moore codebase (in training, moore codebase use the scaled linear as schedule)
updates results after fixing the bug
|
gread job |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I saw that the background was noisy in the previous generation, and I guessed that it could be due to the effect of moore's codebase, I guessed that you still used the "scaled linear" schedule during training, but the inference of moore's codebase is "linear" by default schedule, which is the same as your current inference, so I changed your inference to a "scaled linear" schedule (after aligning it with the training), the background noise was eliminated.