refactor: clean up include dependencies in src/ based on IWYU analysis by LHT129 · Pull Request #2145 · antgroup/vsag

LHT129 · 2026-06-04T09:28:14Z

What

Clean up include dependencies across 148 implementation files (.cpp) in src/ based on IWYU (include-what-you-use) analysis.

Why

IWYU analysis identified the following issues in src/:

Redundant heavy headers: 56 files use <fmt/format.h> but only need <fmt/core.h>
Over-reliance on aggregate headers: common.h, filter_headers.h, io_headers.h, quantizer_headers.h, etc. pull in far more dependencies than needed
Missing explicit includes: Some symbols are only available via transitive dependencies without direct includes

Changes

Commit 1: Replace fmt headers (56 files)

<fmt/format.h> → <fmt/core.h>
No behavioral change; fmt/core.h is a strict subset of fmt/format.h

Commit 2: IWYU include cleanup (148 files)

Split aggregate headers into specific headers actually needed
Add missing explicit includes for symbols used
Remove unused includes
+1,424 lines, -117 lines

Verification

✅ make release build passes
✅ make fmt format check passes

Affected Directories

algorithm/, analyzer/, attr/, datacell/, factory/, impl/, index/, io/, quantization/, simd/, storage/, utils/, src/ root

mergify · 2026-06-04T09:29:01Z

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🟢 Require kind label

Wonderful, this rule succeeded.

label~=^kind/

🟢 Require version label

Wonderful, this rule succeeded.

label~=^version/

gemini-code-assist

Code Review

This pull request replaces the inclusion of <fmt/format.h> with <fmt/core.h> across numerous source and header files to optimize compilation times and minimize dependencies. As there are no review comments, I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Copilot

Pull request overview

This PR updates src/ to prefer the lighter-weight {fmt} header by replacing #include <fmt/format.h> with #include <fmt/core.h> (per IWYU findings), reducing preprocessing overhead without changing runtime behavior.

Changes:

Replaced {fmt} includes across 56 src/ files: <fmt/format.h> → <fmt/core.h>.
No functional logic changes; includes-only refactor intended to improve compile times.

Reviewed changes

Copilot reviewed 56 out of 56 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
src/storage/stream_reader.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/storage/footer.h	Switch `{fmt}` include to `<fmt/core.h>`.
src/reader.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/quantization/transform_quantization/transform_quantizer_parameter_test.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/quantization/rabitq_quantization/rabitq_quantizer_parameter_test.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/quantization/quantizer_parameter.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/options.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/io/reader_io.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/io/mmap_io_parameter_test.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/io/buffer_io_parameter_test.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/io/basic_io.h	Switch `{fmt}` include to `<fmt/core.h>`.
src/io/async_io_parameter_test.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/index/hnsw.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/index/hnsw_zparameters.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/index/diskann_zparameters.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/index_feature_list.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/index_common_param.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/impl/transform/vector_transformer_parameter_test.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/impl/transform/random_orthogonal_transformer.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/impl/transform/pca_transformer.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/impl/odescent/odescent_graph_parameter.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/impl/logger/logger.h	Switch `{fmt}` include to `<fmt/core.h>`.
src/impl/label_table/label_table.h	Switch `{fmt}` include to `<fmt/core.h>`.
src/impl/allocator/default_allocator.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/factory/index_creators.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/datacell/sparse_vector_datacell_parameter.h	Switch `{fmt}` include to `<fmt/core.h>`.
src/datacell/sparse_graph_datacell_test.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/datacell/multi_vector_datacell_test.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/datacell/multi_vector_datacell_parameter.h	Switch `{fmt}` include to `<fmt/core.h>`.
src/datacell/graph_datacell_test.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/datacell/graph_datacell_parameter.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/datacell/flatten_datacell_parameter.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/datacell/extra_info_interface.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/datacell/extra_info_datacell_parameter.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/datacell/compressed_graph_datacell_test.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/datacell/bucket_interface.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/datacell/bucket_datacell_parameter.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/attr/expression_visitor.h	Switch `{fmt}` include to `<fmt/core.h>`.
src/algorithm/warp/warp_parameter.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/algorithm/sindi/term_id_mapper.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/algorithm/ivf/ivf_partition_strategy_parameter.h	Switch `{fmt}` include to `<fmt/core.h>`.
src/algorithm/ivf/ivf_partition_strategy_parameter.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/algorithm/ivf/ivf_parameter.h	Switch `{fmt}` include to `<fmt/core.h>`.
src/algorithm/ivf/ivf_parameter.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/algorithm/ivf/ivf_nearest_partition.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/algorithm/ivf/gno_imi_partition.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/algorithm/ivf/gno_imi_parameter.h	Switch `{fmt}` include to `<fmt/core.h>`.
src/algorithm/ivf/gno_imi_parameter.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/algorithm/inner_index_interface.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/algorithm/hgraph/hgraph.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/algorithm/hgraph/hgraph_serialize.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/algorithm/hgraph/hgraph_search.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/algorithm/hgraph/hgraph_parameter_test.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/algorithm/hgraph/hgraph_param_mapping.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/algorithm/hgraph/hgraph_build.cpp	Switch `{fmt}` include to `<fmt/core.h>`.
src/algorithm/bruteforce/bruteforce_parameter.cpp	Switch `{fmt}` include to `<fmt/core.h>`.

LHT129 · 2026-06-05T05:24:14Z

 #include "reader_io.h"

-#include <fmt/format.h>
+#include <fmt/core.h>

 #include <future>


This file no longer includes fmt/core.h in the latest push — the unused include was already removed.

Copilot

Pull request overview

Copilot reviewed 173 out of 173 changed files in this pull request and generated 9 comments.

LHT129 · 2026-06-05T05:24:35Z

+#include <bits/types/struct_tm.h>
+#include <cxxabi.h>
 #include <unistd.h>

 #include <chrono>


Fixed: removed <bits/types/struct_tm.h> (redundant with ), removed unused <cxxabi.h>, added for std::ostringstream.

LHT129 · 2026-06-05T05:24:57Z

+#include <bits/std_abs.h>
+
+#include <algorithm>
+#include <cstdint>
+#include <unordered_map>


Fixed: replaced <bits/std_abs.h> with across all affected files.

LHT129 · 2026-06-05T05:25:18Z


 #include "lock_strategy.h"

+#include <ext/alloc_traits.h>


Fixed: removed <ext/alloc_traits.h> from all files — it is unused and libstdc++-specific.

LHT129 · 2026-06-05T05:25:42Z


-#include <datacell/compressed_graph_datacell_parameter.h>
-#include <fmt/format.h>
+#include <bits/std_abs.h>


Fixed: removed <bits/std_abs.h>, ensured is present instead.

LHT129 · 2026-06-05T05:26:06Z

 #include <atomic>
+#include <cmath>
+#include <cstdint>
+#include <ext/alloc_traits.h>


Fixed: removed <ext/alloc_traits.h>.

LHT129 · 2026-06-05T05:26:30Z

+#include <cblas.h>
+#include <lapack.h>
+#include <lapacke.h>
 #include <omp.h>


Fixed: restored blas_compat.h and removed direct <cblas.h>/<lapack.h>/<lapacke.h> includes.

LHT129 · 2026-06-05T05:26:51Z

 #include "timer.h"

-#include <numeric>
+#include <ratio>


Fixed: replaced with for std::numeric_limits usage.

LHT129 · 2026-06-05T05:27:10Z

 #include "default_thread_pool.h"

-#include "vsag/options.h"
+#include <cxxabi.h>


Fixed: removed unused <cxxabi.h>.

LHT129 · 2026-06-05T05:27:31Z

 #include <chrono>
-#include <cstring>
+#include <cstdint>
+#include <ext/alloc_traits.h>


Fixed: removed <ext/alloc_traits.h>.

- Replace fmt/format.h with fmt/core.h (56 files) - Split aggregate headers (common.h, filter_headers.h, etc.) into specific headers - Add missing explicit includes for symbols used - Remove unused includes - 148 files changed, +1424 -117 lines Signed-off-by: LHT129 <tianlan.lht@antgroup.com>

Copilot

Pull request overview

Copilot reviewed 172 out of 172 changed files in this pull request and generated 4 comments.

 #include <cstdint>
-#include <fstream>
-#include <iostream>
+#include <limits>
+#include <utility>


+#include <initializer_list>
+#include <map>
 #include <nlohmann/json.hpp>

+#include "nlohmann/detail/json_pointer.hpp"
+#include "nlohmann/json_fwd.hpp"


 #include "async_io_parameter.h"
 #include "buffer_io_parameter.h"
-#include "impl/logger/logger.h"
 #include "inner_string_params.h"


 #include "default_thread_pool.h"

-#include "vsag/options.h"
+#include "ThreadPool.h"


Copilot AI review requested due to automatic review settings June 4, 2026 09:28

LHT129 requested review from inabao, jiaweizone and wxyucs as code owners June 4, 2026 09:28

LHT129 self-assigned this Jun 4, 2026

pull-request-size Bot added the size/L label Jun 4, 2026

Copilot started reviewing on behalf of LHT129 June 4, 2026 09:28 View session

LHT129 added kind/improvement Code improvements (variable/function renaming, refactoring, etc. ) version/1.0 labels Jun 4, 2026

mergify Bot added module/attr module/datacell module/index labels Jun 4, 2026

gemini-code-assist Bot reviewed Jun 4, 2026

View reviewed changes

Copilot AI reviewed Jun 4, 2026

View reviewed changes

pull-request-size Bot added size/XXL and removed size/L labels Jun 4, 2026

mergify Bot added the module/simd label Jun 4, 2026

LHT129 changed the title ~~refactor: replace fmt/format.h with fmt/core.h in src/~~ refactor: 基于IWYU分析清理src/实现文件的include依赖 Jun 4, 2026

LHT129 changed the title ~~refactor: 基于IWYU分析清理src/实现文件的include依赖~~ refactor: clean up include dependencies in src/ based on IWYU analysis Jun 4, 2026

LHT129 force-pushed the opencode/iwyu-cleanup-src-includes branch from 787bbae to 6ff0a2b Compare June 4, 2026 11:22

Copilot AI review requested due to automatic review settings June 4, 2026 11:31

LHT129 force-pushed the opencode/iwyu-cleanup-src-includes branch from 6ff0a2b to 296f33d Compare June 4, 2026 11:31

Copilot started reviewing on behalf of LHT129 June 4, 2026 11:31 View session

Copilot AI reviewed Jun 4, 2026

View reviewed changes

LHT129 force-pushed the opencode/iwyu-cleanup-src-includes branch from 296f33d to c28363a Compare June 5, 2026 05:23

LHT129 force-pushed the opencode/iwyu-cleanup-src-includes branch from c28363a to ebba4f6 Compare June 5, 2026 07:04

Copilot AI review requested due to automatic review settings June 5, 2026 07:04

Copilot started reviewing on behalf of LHT129 June 5, 2026 07:05 View session

Copilot AI reviewed Jun 5, 2026

View reviewed changes

Conversation

LHT129 commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

Why

Changes

Commit 1: Replace fmt headers (56 files)

Commit 2: IWYU include cleanup (148 files)

Verification

Affected Directories

Uh oh!

mergify Bot commented Jun 4, 2026

Merge Protections

🟢 Require kind label

🟢 Require version label

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

LHT129 commented Jun 4, 2026 •

edited

Loading