Refactor hierarchical_mutex example for clarity#23
Open
dozyc wants to merge 1 commit intoanthonywilliams:mainfrom
Open
Refactor hierarchical_mutex example for clarity#23dozyc wants to merge 1 commit intoanthonywilliams:mainfrom
dozyc wants to merge 1 commit intoanthonywilliams:mainfrom
Conversation
Organize code to show the symmetry between unlock and lock. Lock and unlock each have check, action, update pattern, emphasized here. The two exceptions now have more info on the source of the error. Using 'level' instead of 'hierarchical_value' helps quickly and simply convey meaning. Using 'level' allows for better variable names like 'instance_level' and 'thread_level'
Author
|
This change also motivates some updates to the accompanying text, but I think those changes confer more clarity there, too. I suggest replacing all instances of "hierarchy value" with "hierarchy level". The word "level" implies that relative magnitude is important, where "value" does not. Some other recommendations for to the text:
The
Here, each is a little better to emphasize the way the threads have their own copy.
Here, using violated ties to the relevant function names. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Organize code to show the symmetry between unlock and lock.
Lock and unlock each have check, action, update pattern, emphasized here.
The two exceptions now have more info on the source of the error.
Using 'level' instead of 'hierarchical_value' helps quickly and simply convey meaning.
Using 'level' allows for better variable names like 'instance_level' and 'thread_level'