Open
Conversation
- current function returns a mismatch of iterators (const vs non-const) No viable conversion from returned value of type.... 'std::__list_const_iterator<std::pair<int, int>, void *>' ...to function return type... 'ts::map<int, int>::bucket_type::bucket_iterator' ...(aka '__list_iterator<std::pair<int, int>, void *>') - a better solution would be to preserve const-ness, but this will do for now
- consider removing `const` to allow programme to compile - 'this' argument to member function 'find_entry_for' has type... - 'const ts::map<int, int>::bucket_type', ... - ...but function is not marked const
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consider changing line 23 from...
ccia_code_samples/listings/listing_6.11.cpp
Line 23 in 6e7ae1d
...to...
ccia_code_samples/listings/listing_6.11.cpp
Line 23 in e893b0c
Doesn't preserve const-ness, but fixes the following error, and allows for the code to run.
Line 30...
ccia_code_samples/listings/listing_6.11.cpp
Line 30 in 6e7ae1d
...should then also be changed to...
ccia_code_samples/listings/listing_6.11.cpp
Line 30 in 14a87fc
...to avoid the following compilation warning.