Listing 7.18 / 7.19 / 7.20 - Potential Data Race#38
Open
ITHelpDec wants to merge 1 commit intoanthonywilliams:mainfrom
Open
Listing 7.18 / 7.19 / 7.20 - Potential Data Race#38ITHelpDec wants to merge 1 commit intoanthonywilliams:mainfrom
ITHelpDec wants to merge 1 commit intoanthonywilliams:mainfrom
Conversation
- consider upgrading to std::memory_order_acq_rel to ensure all accesses to ptr_ happen before its deletion
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given the following reading material here and here, please consider upgrading the memory-ordering of our
.compare_exchange_strong()operations from......to...
...to ensure all accesses to
ptrhappen before its deletion.Attached are examples of before and after results from Godbolt using thread sanitiser.
Thank you to Nate Eldridge for the great explanation and testing.