Open
Conversation
Two headers needed for compilation on gcc and clang + #include <numeric> // std::accumulate + #include <functional> // std::mem_fn (Apple Clang only needs <numeric>)
"Parentheses were disambiguated as a function declaration"
- extra parentheses needed to call `accumulate_block<Iterator,T>::operator()` in place of default constructor "No matching constructor for initialization of 'accumulate_block<std::__wrap_iter<int *>, int>'"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
<numeric>and<functional>)std::packaged_taskis constructed incorrectly (requires extra parentheses)accumulate_blockis mistakenly called in place ofaccumulate_block<Iterator,T>::operator()Stylistically it might also be nice to replace lines 50-51...
ccia_code_samples/listings/listing_8.3.cpp
Lines 50 to 51 in 6e7ae1d
... with a range-based for loop.
Tested successfully on gcc, clang and apple clang.