Listing 8.13 - Incorrect Implementation#45
Open
ITHelpDec wants to merge 3 commits intoanthonywilliams:mainfrom
Open
Listing 8.13 - Incorrect Implementation#45ITHelpDec wants to merge 3 commits intoanthonywilliams:mainfrom
ITHelpDec wants to merge 3 commits intoanthonywilliams:mainfrom
Conversation
* libc++abi: terminating, otherwise
* without this inverted else statement, the code produces incorrect partial sums
* block_start is not used in algorithm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of this has been addressed in an earlier issue, so thank you to @dragon-dreamer and @xxrlzzz.
As it stands, an incomplete
join_threadswill result in a runtime error, and functionally we need to ensure anelsestatement is included shouldupdate_sourcenot returntrue.Our
block_startiterator is also unused, so maybe this was a throwback to earlier examples whereblock_startandblock_endwere passed recursively?Good catch, guys / dolls.