Open
Conversation
- opted for version that returns type _Tp - - void version in book takes three arguments - - _Tp version in book takes two
- struct called without arguments - add arguments according to earlier operator() definition
- book passes accumulate_block as part of a lambda function
- accumulate_block::operator() returns type _Tp - we must call `return` on the struct's call inside the lambda to capture this return type - without this, the code will fail to compile, and provide the following error: - - "No viable overloaded '='"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
returnis needed when calling the two-parameter version ofaccumulate_block()inside of the lambda function.futures[i] = pool.submit([=] () { - accumulate_block<_ForwardIt, _Tp>()(block_start, block_end); + return accumulate_block<_ForwardIt, _Tp>()(block_start, block_end); });Without it, we receive the following error:
No viable overloaded '='The listing in this repo (here) also doesn't mirror what was written in the book, so I've first brought them in sync before applying the correction.