Conversation
docs/benchmark-results.md ships in the repo and tells readers to "Reproduce These Results" with `curl -L -o benchmarks/data/...`, but the benchmarks/ directory and the runner script were never in the repo — the published numbers (R@1=0.880, R@10=0.986, NDCG@10=0.924) weren't reproducible. This adds: - benchmarks/longmemeval_bench.py — the runner. Three modes (raw, hybrid, full). Embedding: BAAI/bge-small-en-v1.5 (production model). Qdrant in-memory per question. Same metrics as MemPalace for apples-to-apples comparison. - benchmarks/README.md — download + run instructions. - .gitignore — adds benchmarks/data/ so the ~277 MB dataset can sit on disk without risk of accidental commit. No external dependencies beyond what the project already uses (fastembed, qdrant_client).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
docs/benchmark-results.md(already onmain) citesR@1 = 0.880,R@10 = 0.986,NDCG@10 = 0.924and gives users a "Reproduce These Results" section with:mkdir -p benchmarks/data curl -L -o benchmarks/data/longmemeval_s_cleaned.json \ "https://huggingface.co/datasets/xiaowu0162/longmemeval-cleaned/..."…but
benchmarks/doesn't exist in the repo. Anyone trying to reproduce ends with a downloaded dataset and no runner.This commits the script behind the published numbers.
What
benchmarks/longmemeval_bench.py— the runner. Three modes:raw— pure vector similarity (baseline, like MemPalace raw)hybrid— vector + BM25 keyword scoring (OpenExp default)full— vector + BM25 + recencyBAAI/bge-small-en-v1.5(same as production)benchmarks/README.md— download URL, dataset format, three example invocations, expected runtime, expected numbers.gitignore—benchmarks/data/added so the ~277 MB dataset can sit on disk without risk of accidental commitNo new dependencies. Uses
fastembedandqdrant_clientalready in the project.Test plan
python benchmarks/longmemeval_bench.py benchmarks/data/longmemeval_s_cleaned.json --mode hybrid --limit 20— should run end-to-end on 20 questions in a few minuteshybridmode reproduces the numbers indocs/benchmark-results.md(R@1 ≈ 0.880, R@10 ≈ 0.986, NDCG@10 ≈ 0.924)