Conversation
- Refactor type_test binary to use schema/queries subcommands - Add *.queries.sql files with example queries for each schema - Add *.queries.json expected argument and output-column types - Update test.py to discover and run query tests automatically
Adds the sqlx-type-schema.sql from simpleadmin as a new test case covering the SQLite dialect. The queries file covers all query! macros used in the simpleadmin server. simpleadmin.queries.json is not yet committed because a recently introduced bug in qusql-type prevents the query typer from running against this schema. Once fixed, run test.py --update to generate it.
…ases
Add a new FROM_ALIAS restrict set containing LEFT, RIGHT, INNER, CROSS,
FULL, NATURAL, OUTER, JOIN, and STRAIGHT_JOIN. Apply it only to the
implicit alias detection in parse_table_reference_named so that e.g.
FROM docker_images LEFT JOIN docker_deployments ON ...
is no longer parsed as table docker_images with implicit alias LEFT
followed by a plain JOIN. Explicit AS aliases are unaffected.
These keywords are not reserved in SQLite (valid as unquoted column
names), so they cannot be added to Restrict::SQLITE; a dedicated
context-specific restrict set is the correct fix.
Generate query type baseline now that the parser bug (join keywords being consumed as implicit table aliases) is fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.