fix(bedrock): remove :0 suffix from Anthropic model IDs#2750
Open
i010542 wants to merge 3 commits intoantinomyhq:mainfrom
Open
fix(bedrock): remove :0 suffix from Anthropic model IDs#2750i010542 wants to merge 3 commits intoantinomyhq:mainfrom
i010542 wants to merge 3 commits intoantinomyhq:mainfrom
Conversation
…tibility When the zsh-vi-mode plugin (jeffreytse/zsh-vi-mode) is active, the Enter key in vi-command mode does not trigger forge's colon commands. Users report 'command not found: :model' and similar errors. Root cause: bindkey '^M' only sets the binding in the current keymap. In vicmd mode, Enter is bound to vi-accept-line, not forge-accept-line. Fix: also bind Enter and Tab in vicmd mode when zsh-vi-mode is detected. Detection uses $ZVM_MODE (zsh-vi-mode plugin) or bindkey -lL main (native vi mode via bindkey -v). Fixes: antinomyhq#2681 Co-Authored-By: ForgeCode <noreply@forgecode.dev>
Resolves: antinomyhq#2662 - Add FORGE_FOLDER_PATH env var to override default ~/forge path - Priority: FORGE_FOLDER_PATH > ~/forge > ./forge fallback - No breaking changes to existing behavior Co-Authored-By: Atlas Bounty Hunter <atlas@opencode.ai>
Bedrock API rejects model IDs with :0 suffix for Anthropic models. This change removes the :0 suffix before adding the regional prefix. Fixes antinomyhq#2644 Co-Authored-By: ForgeCode <noreply@forgecode.dev>
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bedrock API rejects model IDs with
:0suffix for Anthropic models (e.g.,anthropic.claude-3-5-sonnet-20241022-v2:0). This fix removes the:0suffix before adding the regional prefix.Changes
transform_model_id()inbedrock.rsto strip:0suffix from Anthropic model IDs before adding regional prefixFixes
Fixes #2644