fix: clear thought_signature in DropReasoningDetails transformer#2751
Open
majiayu000 wants to merge 1 commit intoantinomyhq:mainfrom
Open
fix: clear thought_signature in DropReasoningDetails transformer#2751majiayu000 wants to merge 1 commit intoantinomyhq:mainfrom
majiayu000 wants to merge 1 commit intoantinomyhq:mainfrom
Conversation
DropReasoningDetails only cleared reasoning_details but left thought_signature intact. When switching from a provider like MiniMax back to Claude, the leftover signature caused a 400 error because Claude rejects unknown thinking block signatures. ReasoningNormalizer already clears both fields on model change, but DropReasoningDetails (used when the target model does not support reasoning at all) missed the thought_signature field. Signed-off-by: majiayu000 <1835304752@qq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DropReasoningDetailsonly clearedreasoning_detailsbut leftthought_signatureintact on text messagestext.thought_signature = None;alongside the existingtext.reasoning_details = None;to match the behavior ofReasoningNormalizerwhich already clears both fieldsFixes #2646
Test plan
test_drop_reasoning_clears_thought_signature— creates an assistant message with bothreasoning_detailsandthought_signatureset, runsDropReasoningDetails, asserts both areNonecargo test --all-features --workspace)RUSTFLAGS='-Dwarnings' cargo check --all-features --workspacepasses