-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Move global Forge data to ~/.config/forge (XDG compliant) #2817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ravshansbox
wants to merge
6
commits into
antinomyhq:main
Choose a base branch
from
ravshansbox:issue-2451-hidden-global-forge-dir
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
b943f25
Move global Forge data to ~/.forge
ravshansbox ec3e68d
[autofix.ci] apply automated fixes
autofix-ci[bot] 203eb35
Update crates/forge_infra/src/env.rs
ravshansbox 8048c02
Make Forge base path XDG-compliant
ravshansbox c125d3f
[autofix.ci] apply automated fixes
autofix-ci[bot] 478a2bf
Update crates/forge_config/src/reader.rs
ravshansbox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -417,7 +417,7 @@ function _forge_action_reasoning_effort() { | |||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| # Action handler: Set reasoning effort in global config. | ||||||||||||||||||||||||||||||||
| # Calls `forge config set reasoning-effort <effort>` on selection, | ||||||||||||||||||||||||||||||||
| # writing the chosen effort level permanently to ~/forge/.forge.toml. | ||||||||||||||||||||||||||||||||
| # writing the chosen effort level permanently to ~/.forge/.forge.toml. | ||||||||||||||||||||||||||||||||
| function _forge_action_config_reasoning_effort() { | ||||||||||||||||||||||||||||||||
| local input_text="$1" | ||||||||||||||||||||||||||||||||
| ( | ||||||||||||||||||||||||||||||||
|
|
@@ -470,12 +470,12 @@ function _forge_action_config_edit() { | |||||||||||||||||||||||||||||||
| return 1 | ||||||||||||||||||||||||||||||||
| fi | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| local config_file="${HOME}/forge/.forge.toml" | ||||||||||||||||||||||||||||||||
| local config_file="${HOME}/.forge/.forge.toml" | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
| # Ensure the config directory exists | ||||||||||||||||||||||||||||||||
| if [[ ! -d "${HOME}/forge" ]]; then | ||||||||||||||||||||||||||||||||
| mkdir -p "${HOME}/forge" || { | ||||||||||||||||||||||||||||||||
| _forge_log error "Failed to create ~/forge directory" | ||||||||||||||||||||||||||||||||
| if [[ ! -d "${HOME}/.forge" ]]; then | ||||||||||||||||||||||||||||||||
| mkdir -p "${HOME}/.forge" || { | ||||||||||||||||||||||||||||||||
| _forge_log error "Failed to create ~/.forge directory" | ||||||||||||||||||||||||||||||||
|
Comment on lines
+473
to
+478
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Shell script is using incorrect path local config_file="${HOME}/.config/forge/.forge.toml"
if [[ ! -d "${HOME}/.config/forge" ]]; then
mkdir -p "${HOME}/.config/forge" || {
_forge_log error "Failed to create ~/.config/forge directory"
Suggested change
Spotted by Graphite |
||||||||||||||||||||||||||||||||
| return 1 | ||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||
| fi | ||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Migration fallback logic is incorrect. When
dirs::home_dir()returnsNone, this falls back toxdg_config_dir(), makingold_base_path()return~/.config/forge(same as new path). This breaks migration detection since old and new paths would be identical.Spotted by Graphite

Is this helpful? React 👍 or 👎 to let us know.