fix: resolve unreachable pattern warning in image paste PR #2823

[Dhilan-Panjabi]

Fixes the unreachable pattern warning introduced in #2823.

Problem

The Paste variant was incorrectly placed between AgentSwitch's #[strum(props(...))]" attribute and its variant declaration, causing two strum attributes to stack on Pasteand leavingAgentSwitch` without its metadata.

Fix

• Separated Paste and AgentSwitch into their own properly annotated blocks
• Removed extra blank line

Builds clean with zero warnings.

[CLAassistant]

All committers have signed the CLA.

[graphite-app]

Debug logging code appears to have been accidentally left in production code. This creates a file at /tmp/forge_paste.log on every paste attempt, which could fill up disk space over time and expose user activity. This block should be removed:

if let Ok(mut f) = std::fs::OpenOptions::new()
    .create(true)
    .append(true)
    .open("/tmp/forge_paste.log")
{
    let _ = writeln!(&mut f, "Received !forge_internal_paste_image");
    use std::io::Write;
}

Spotted by Graphite



Is this helpful? React 👍 or 👎 to let us know.

[graphite-app]

Using HOME environment variable for cross-platform path resolution is unreliable. On Windows, HOME is typically not set, causing this to fall back to /tmp which also doesn't exist on Windows. This will cause directory creation to fail silently, and image pasting won't work on Windows. Should use dirs::data_local_dir() or similar platform-aware solution:

use dirs;
fn get_images_dir() -> Option<PathBuf> {
    let base_dir = dirs::data_local_dir()?;
    let images_dir = base_dir.join("forge/images");
    std::fs::create_dir_all(&images_dir).ok()?;
    Some(images_dir)
}

Spotted by Graphite



Is this helpful? React 👍 or 👎 to let us know.