You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This PR changes apps/review-agent/src/webhook/handler.ts so the webhook can submit body-only COMMENT reviews when there is a status update to post, instead of skipping GitHub review creation whenever inline comments are absent.
shouldSubmitReview() now considers a non-empty review body, which enables status-only review submissions for COMMENT events.
The handler now builds status updates from tracked history by converting StoredIssueRecord entries back into CodeIssue objects via storedIssueToCodeIssue().
The status-update path distinguishes unresolved historical findings from genuinely new findings with statusUpdateNewIssues, so duplicate-suppressed legacy fingerprints do not force fresh status updates.
formatReviewBody() is now fed a historical/open-issue view when appropriate, while the living summary comment still comes from formatHistoricalSummaryBody() and is upserted as before.
apps/review-agent/src/webhook/handler.test.ts adds coverage for repeated historical issues, addressed historical issues, and the new expectation that a body-only status update produces a submitted COMMENT review with a review id.
Safe to merge. I checked the new review-submission path, the historical-issue reconstruction logic, and the interaction with existing duplicate-suppression and summary-comment flows. The body-only COMMENT review behavior is consistent with the existing GitHub client contract, the historical status update logic preserves unresolved and addressed tracked findings without reintroducing duplicate inline comments, and I did not find a blocking security, correctness, or performance regression in the changed paths. Residual risk is limited to integration behavior with GitHub's review API for body-only comments, but the code and tests are aligned with that intended flow.
Findings
OpenDiff found no issues that require changes in this review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation