Open
Conversation
Upgraded maven-compiler-plugin to 3.14.1, maven-shade-plugin to 3.6.1, and various dependencies (e.g., velocity-api to 3.4.0-SNAPSHOT, gson to 2.13.2, and more)
…matRemainingTime Standardized all occurrences of getFormattedRemainingTime to the newer formatRemainingTime method for consistency and streamlined functionality.
Updated Java version requirement and configuration from 1.8 to 11 in POM files and README for compatibility and modernization.
… steps - Added Java version matrix support for better testing coverage. - Split build steps for PRs and pushes with conditional logic. - Improved artifact handling and caching for Maven builds.
Updated Java version requirement and configuration from 11 to 17 in POM files, README, and CI workflow for compatibility and modernization.
Fix formatting issues in the README regarding ban levels.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the project to require Java 17, modernizes the build and dependency setup, and improves documentation formatting and clarity. The most important changes are grouped below.
Build and CI Improvements
.github/workflows/build.ymlis updated to use Java 17, matrix builds, Maven caching, and separate build steps for pull requests and pushes. The workflow now supports bothmasteranddevelopbranches for PRs, and uses updated actions versions for checkout and Java setup.Dependency and Project Configuration
pom.xmlfiles (pom.xml,BanSystem-SpigotChatAdapter/pom.xml,BanSystem-SpigotChatAdapter/dependency-reduced-pom.xml,BanSystem-StatisticServer/pom.xml) now specify Java 17 as the required version, update plugin versions, and bump several dependency versions (e.g., Velocity, Floodgate, SQLite JDBC, Gson, SnakeYAML, MySQL Connector). The main project version is incremented to 3.3 and a new repository for releases is added. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]Documentation Updates
README.mdis revised to state Java 17 as the minimum requirement and improves formatting for installation steps, API key instructions, and permissions tables for better readability. [1] [2] [3]Codebase Maintenance
SpigotChatAdapter.javaand removal of redundant vendor tags in Maven manifests. [1] [2]API and Instance Management
BanSysteminterface andBanSystemBungeeclass are refactored for clearer static instance management and caching of banned/muted player names, improving code organization and maintainability. [1] [2] [3] [4] [5]