Skip to content

Jess/694 revert public - #695

Open
jesscmoore wants to merge 6 commits into
linkingfrom
jess/694_revert_public
Open

Jess/694 revert public#695
jesscmoore wants to merge 6 commits into
linkingfrom
jess/694_revert_public

Conversation

@jesscmoore

Copy link
Copy Markdown
Collaborator

Pull Request Details

Description

This implements the revoke of public/auth sharing that is required when such a file is then shared privately to a specific user or group

Related Issues

See also solidui issue 393 which creates a confirmation dialog.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How To Test?

  1. Open Exper or other app
  2. Share a file to auth users with read
  3. Confirm by looking at Current permissions or logging in as any user
  4. Share the same file privately to a specific user.
  5. Confirm by looking at Current permissions

Checklist

  • Screenshots included here/in linked issue #
  • Changes adhere to the style and coding guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • The update contains no confidential information
  • The update has no duplicated content
  • No lint check errors are related to these changes (make prep or flutter analyze lib)
  • Integration test dart test output or screenshot included in issue #
  • I tested the PR on these devices:
    • Android
    • iOS
    • Linux
    • MacOS
    • Windows
    • Web
  • I have identified reviewers
  • The PR has been approved by reviewers

Finalising

  • Merge dev into the this branch
  • Resolve any conflicts
  • Add a one line summary into the CHANGELOG.md
  • Push to the git repository and review
  • Merge the PR into dev

@jesscmoore
jesscmoore requested a review from cdawei July 28, 2026 12:06
@jesscmoore
jesscmoore changed the base branch from dev to linking July 29, 2026 02:33
@jesscmoore
jesscmoore requested review from anushkavidanage and tonypioneer and removed request for tonypioneer July 29, 2026 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant