Jess/381 pod linking

[jesscmoore]

Pull Request Details

Description

This allows a user logged in to their webid to view their webid file, eg jessicamoore/profile/card$.ttl and link another pod on another Solid server by temporarily adding the oidcRegistrationToken of server 2, and adding server 2 as a oidcIssuer.

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How To Test?

Use notepod or other solid app, pointed to this branch of solidui

Checklist

• Screenshots included here/in linked issue #SOLIDUI: allow linking a new pod to webid in profile settings #381
• Changes adhere to the style and coding guidelines
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• Any dependent changes have been merged and published in downstream modules
• The update contains no confidential information
• The update has no duplicated content
• No lint check errors are related to these changes (make prep or flutter analyze lib)
• Integration test dart test output or screenshot included in issue #
• I tested the PR on these devices:
  • Android
  • iOS
  • Linux
  • MacOS
  • Windows
  • Web
• I have identified reviewers
• The PR has been approved by reviewers

Finalising

• Merge dev into the this branch
• Resolve any conflicts
• Add a one line summary into the CHANGELOG.md
• Push to the git repository and review
• Merge the PR into dev

[cdawei]

I followed these steps to test this PR.

1. Register a CSS account, and create a POD (in section Pods, click the Create pod link, provide the POD name, and choose to use an external WebID, say WebID1).

2. Link the WebID used in step 1 (i.e., WebID1) to the CSS account (in section Registered Web IDs of the above screenshot, click Link WebID), after clicking Link WebID to account`, a page with registration token is shown.

3. Use a solidui based app, login with a CSS account linked with WebID1 (not the newly registered account), go to the profile page, click Link another Pod, and provide the POD server URL and the token from step 2, click Add Token. Then follow the on-screen instructions in the app to finishing the linking.

4. After successfully linking WebID1 with a newly created POD (and the corresponding CSS account), one can then login a solidui based app using the new CSS account and WebID1. Note that solidpod may check the app's security key against the one in appDir/encryption/enc-key.ttlin WebID1's default POD, not appDir/encryption/enc-key.ttl in the newly created POD due to issue SOLID POD: Derive resource URL from POD server URL instead of WebID solidpod#692

[cdawei]

The functionality worked as expected in my test, as noted in this comment, thanks Jess.

One observation: The current implementation does not seem to check if a server has already been linked, so it's possible to link the same server multiple times (as shown in the screenshot below).

[jesscmoore]

Thanks Dawei, the last commit should have prevented duplicate oidcIssuers, but looks like it didn't catch your use pattern. I'll check and fix it.

[jesscmoore]

The current implementation does not seem to check if a server has already been linked, so it's possible to link the same server multiple times (as shown in the screenshot below).

@cdawei please check again. I've fixed it to make the check of duplicate oidcIssuer more robust.

[cdawei]

@cdawei please check again. I've fixed it to make the check of duplicate oidcIssuer more robust.

I did another test to link a different POD on a server which is already an oidcIssuer, no duplicated triples added. Thanks Jess.

[jesscmoore]

@jesscmoore to resolve conflicts and @tonypioneer to do test.

[jesscmoore]

Hi @tonypioneer conflicts resolved, ready for review.

[tonypioneer]

Thanks @jesscmoore. After testing, I was able to successfully link another POD, and an appropriate error message is displayed if a server has already been linked.

At the moment, the only issue I've noticed is that there are still conflicts in Changelog.md. Also, if I remember correctly, we mentioned in yesterday's meeting that the Settings menu could be renamed to something like Profile Settings.

[jesscmoore]

Thanks Tony. Settings menu renamed to Profile Settings. If that's too long, can make it just Profile.
And dev merged again and conflicts resolved.

[tonypioneer]

Thanks Tony. Settings menu renamed to Profile Settings. If that's too long, can make it just Profile. And dev merged again and conflicts resolved.

Thanks @jesscmoore. The Profile Settings menu name is just the right length. All looks good to me.

[gjwgit]

This requires updates to solidpod, is part of a work in progress and suggest we use a 'linking' branch to capture this work in progress.