Jess/392 revert public - #394
Open
jesscmoore wants to merge 8 commits into
Open
Conversation
Contributor
|
Include this into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
Review and merge - #390 first
Description
This branch provides the confirmation dialog to user when they are switching a public/auth user shared file back to private sharing. It follows the same UI design as the similar dialog when user is sharing the other way (private -> public).
Related Issues
Issue #393
Type of Change
How To Test?
Use a Solid app that supports peer to peer sharing.
Share a file to auth users/public + read
Then share the file privately back to a specific user.
Revoking and encrypting is handled.
Checklist
make preporflutter analyze lib)dart testoutput or screenshot included in issue #Finalising