Skip to content

Jess/392 revert public - #394

Open
jesscmoore wants to merge 8 commits into
linkingfrom
jess/392_revert_public
Open

Jess/392 revert public#394
jesscmoore wants to merge 8 commits into
linkingfrom
jess/392_revert_public

Conversation

@jesscmoore

@jesscmoore jesscmoore commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Pull Request Details

Review and merge - #390 first

Description

This branch provides the confirmation dialog to user when they are switching a public/auth user shared file back to private sharing. It follows the same UI design as the similar dialog when user is sharing the other way (private -> public).

Related Issues

Issue #393

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How To Test?

Use a Solid app that supports peer to peer sharing.
Share a file to auth users/public + read
Then share the file privately back to a specific user.

Revoking and encrypting is handled.

Checklist

  • Screenshots included here/in linked issue #
  • Changes adhere to the style and coding guidelines
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules
  • The update contains no confidential information
  • The update has no duplicated content
  • No lint check errors are related to these changes (make prep or flutter analyze lib)
  • Integration test dart test output or screenshot included in issue #
  • I tested the PR on these devices:
    • Android
    • iOS
    • Linux
    • MacOS
    • Windows
    • Web
  • I have identified reviewers
  • The PR has been approved by reviewers

Finalising

  • Merge dev into the this branch
  • Resolve any conflicts
  • Add a one line summary into the CHANGELOG.md
  • Push to the git repository and review
  • Merge the PR into dev

@jesscmoore
jesscmoore requested a review from cdawei July 28, 2026 22:42
@jesscmoore
jesscmoore requested a review from gjwgit July 28, 2026 22:48
@gjwgit

gjwgit commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Include this into linking branch

@jesscmoore
jesscmoore changed the base branch from dev to linking July 29, 2026 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants