Skip to content

feat(profile): add max_length validation constraint on bio field #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emre155 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(profile): add max_length validation constraint on bio field #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
"""Data models for the Workshop API."""

from pydantic import BaseModel
from pydantic import BaseModel, Field
from typing import Optional


class ProfileCreate(BaseModel):
"""Schema for creating a new profile."""

username: str
bio: str
bio: str = Field(..., max_length=500)
age: Optional[int] = None


Expand Down
8 changes: 8 additions & 0 deletions tests/test_profile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,11 @@ def test_get_profile(clean_store):
def test_get_nonexistent_profile(clean_store):
response = client.get("/profile/nobody")
assert response.status_code == 404


def test_create_profile_with_too_long_bio(clean_store):
response = client.post(
"/profile",
json={"username": "alice", "bio": "x" * 501, "age": 22},
)
assert response.status_code == 422