Open
Conversation
This was referenced Jan 6, 2026
3 tasks
deff7
requested changes
Feb 10, 2026
stevelr
force-pushed
the
filter-bool-number
branch
2 times, most recently
from
a51a434 to
3cfb879
Compare
stevelr
force-pushed
the
filter-bool-number
branch
from
3cfb879 to
5777aa4
Compare
deff7
reviewed
Feb 12, 2026
deff7
reviewed
Feb 12, 2026
Resolve merge conflicts in core/api/filter/validator.go and validator_test.go by combining checkbox/number parsing with upstream's select tag validation. Take upstream go.mod/go.sum.
Contributor
Author
|
@deff7 |
Member
|
@stevelr Hi, looks like you've merged two separate PRs into this one. Could you please remove changes not related to the original PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
filters of the form "property_type=value" do not work for
Also, [in] and [not-in] conditions don't work for numbers.
The error returned in "property type is not a boolean/number"
I didn't add support for bool property [in] and [not-in] since I didn't think it made sense.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #2879
This is one of three bug fix PRs that arose out of testing object queries and filters in a rust SDK for Anytype (the problems can be reproduced with curl so they are not rust-related).
2881 Filter bool numbers
2880 core/api: allow type object ids in type filters
2882 core/api/filter: allow select tag ids
To keep the changes simpler and easier to review, they are separate PRs. I have another branch that combines them for testing - let me know if you'd rather I submit that as a PR instead.
Mobile & Desktop Screenshots/Recordings
N/A
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
N/A