Fix RunProfiler temp file creation on Android#2899
Draft
konstantiniiv wants to merge 1 commit intodevelopfrom
Draft
Fix RunProfiler temp file creation on Android#2899konstantiniiv wants to merge 1 commit intodevelopfrom
konstantiniiv wants to merge 1 commit intodevelopfrom
Conversation
Use TempDirProvider to get a platform-appropriate temp directory instead of relying on os.TempDir(). On Android, the system temp directory is not writable by the app, causing RunProfiler to fail when creating the profile ZIP file. The new getTempDir helper retrieves the temp directory from TempDirProvider (which creates a temp directory inside the wallet root path) and falls back to os.TempDir() if the app container is not available.
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use TempDirProvider to get a platform-appropriate temp directory instead of relying on os.TempDir(). On Android, the system temp directory is not writable by the app, causing RunProfiler to fail when creating the profile ZIP file.
The new getTempDir helper retrieves the temp directory from TempDirProvider (which creates a temp directory inside the wallet root path) and falls back to os.TempDir() if the app container is not available.
Description
What type of PR is this? (check all applicable)
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?