GO-6032 Protect angle brackets in HTML-to-blocks pipeline#3035
Draft
GO-6032 Protect angle brackets in HTML-to-blocks pipeline#3035
Conversation
Add < and > to the protectedRunes escape list so that HTML entities (< >) decoded during HTML→markdown conversion are not misinterpreted as raw HTML tags by goldmark. This fixes pasting code containing angle brackets (arrow functions, generics, JSX) from clipboard sources that only provide HTML. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Coverage provided by https://github.com/seriousben/go-patch-cover-action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<and>to theprotectedRunesescape list inanymark/escape.go</>entities (e.g. from CodeMirror copy buttons, ViolentMonkey, IDE copy buttons), the html-to-markdown library decodes them to bare</>, which goldmark then misinterprets as HTML tags and silently drops[,],*, etc.) — this extends it to also protect angle bracketsTest plan
TestEscapeUnescapeAngleBrackets— round-trip escape/unescape preserves<and>TestHTMLToBlocks_AngleBrackets— HTML entities, arrow functions, JSX, generics, comparison operators all preserved throughHTMLToBlocksTestClipboard_PasteHtmlWithAngleBrackets— end-to-end paste into code blocks and paragraphs preserves angle bracketsTestConvertHTMLToBlocksJSON test cases still pass (including underline<u>tags)🤖 Generated with Claude Code