GO-6803 Fix Set by Relation not finding objects with unactivated properties#3047
Open
GO-6803 Fix Set by Relation not finding objects with unactivated properties#3047
Conversation
…erties When querying by relation source (e.g. "Set by Relation: Done"), the subscription filter now also matches objects whose type recommends the relation, not just objects that physically have the key in their details. This fixes the case where a relation is added to a type but existing objects never get the key written until the user interacts with it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Coverage provided by https://github.com/seriousben/go-patch-cover-action |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
typesRecommendingRelation()helper that queries the object store for types whoserecommendedRelations,recommendedFeaturedRelations, orrecommendedHiddenRelationscontain the given relationFilterExists{Key} OR TypeIn(types recommending relation), with graceful fallback to the originalFilterExists-only behavior on errorsLinear
GO-6803
Test plan
"relation source includes objects whose type recommends the relation"— verifies objects without the key but with a recommending type are found, while objects of unrelated types are excludedgo test ./core/subscription/...)go test ./pkg/lib/database/...)🤖 Generated with Claude Code