GO-6869 Exclude nightly tags from git describe in CI workflows#3064
Merged
requilence merged 1 commit intodevelopfrom Apr 15, 2026
Merged
GO-6869 Exclude nightly tags from git describe in CI workflows#3064requilence merged 1 commit intodevelopfrom
requilence merged 1 commit intodevelopfrom
Conversation
Add --exclude='*-nightly.*' to git describe so release builds always pick the actual release tag when both a nightly and release tag exist on the same commit.
Coverage provided by https://github.com/seriousben/go-patch-cover-action |
deff7
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--exclude='*-nightly.*'togit describeinbuild.yml,perftests-grafana.yml, andperftests.ymlnightly.ymlalready computes its version explicitly and is unaffectedProblem
git describe --tags --alwayspicks tags non-deterministically when multiple tags point to the same commit. A nightly tag likev0.44.0-nightly.20260307.1can be selected over the actual release tagv0.49.0, causing the built binary to report an incorrect version.Fix
Test plan