improve build instructions#2037
Merged
ra3orblade merged 4 commits intoanyproto:developfrom Mar 20, 2026
Merged
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
pompydev
added a commit
to pompydev/anytype-heart
that referenced
this pull request
Mar 7, 2026
16 tasks
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
Contributor
|
Hello, sorry I'm not answering because I was waiting middleware to merge your PR. |
zarkone
reviewed
Mar 19, 2026
Comment on lines
+32
to
35
| # anytype-heart | ||
| grpc-tools | ||
| protobuf | ||
|
|
Contributor
There was a problem hiding this comment.
hey, thanks for the contribution! 🙏 we have a separate nix flake in anytype-heart which handles protobuf things. so all the new bits of flake.nix seem redundant. Or do you experience any problems with heart's flake?
Contributor
Author
There was a problem hiding this comment.
I'm not having issues per se but it saves people from having to switch nix shell or launch multiple terminals at the cost of two lines of code duplication. It also makes the instruction easier to follow.
ra3orblade
approved these changes
Mar 19, 2026
Contributor
|
Resolve conflicts please and I'll merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR simplifies the build process for contributors and makes the instruction more clear.
Here's all the changes:
libsecretandjqis only two of many dependencies contributors will have to hunt down regardless of whether we keep the list or not. Instead, I added a command to use theflake.nixfile to create a shell with all the dependencies needed to build anytype-ts and anytype-heart.PROTOBUF_INCLUDEenvironment variable will be used in use PROTOBUF_INCLUDE environment variable if it is defined anytype-heart#3003What type of PR is this?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?