Enforce 64-instruction transaction limit across kit#1157
Closed
rajgoesout wants to merge 1 commit intoanza-xyz:mainfrom
Closed
Enforce 64-instruction transaction limit across kit#1157rajgoesout wants to merge 1 commit intoanza-xyz:mainfrom
rajgoesout wants to merge 1 commit intoanza-xyz:mainfrom
Conversation
- add instruction-limit types/constants and new error code/message/context - enforce limit in message append/prepend, compilation, and instruction planning - propagate instruction-limit typing through transactions, signers, and react - add unit/typetests for message/transaction limits and sendable checks Closes anza-xyz#1102
🦋 Changeset detectedLatest commit: 12dcf84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 43 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
BundleMonFiles updated (19)
Unchanged files (117)
Total files change +2.02KB +0.52% Final result: ✅ View report in BundleMon website ➡️ |
mcintyre94
reviewed
Jan 8, 2026
Member
mcintyre94
left a comment
mcintyre94
left a comment
There was a problem hiding this comment.
Thanks a lot for picking this up and working on it! I wasn't expecting this to be picked up so quickly after I created the issue, and I need to think a bit more about the design and complexity here. We don't need to rush this because it isn't critical until we have v1 transactions with the larger size limit. And as-is this would be a major bump which I don't want to take lightly.
I'm going to put this PR in draft so we don't accidentally merge it for now.
mcintyre94
added
the
do-not-close
Member
|
Superseded by #1496 - so I'll close this, but thankyou! |
Contributor
|
Because there has been no activity on this PR for 14 days since it was merged, it has been automatically locked. Please open a new issue if it requires a follow up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
SIMD‑0296 raises the transaction byte limit to 4096, but the instruction count cap stays at 64.
Kit currently enforces size, not instruction count, so transactions could exceed 64 instructions once the size limit increases.
We need to enforce the 64‑instruction limit when building/compiling messages and when planning transactions.
Summary of Changes
Closes #1102