RPC: Include index in getSignaturesForAddress response #1246#1248
Draft
sdt03 wants to merge 3 commits intoanza-xyz:mainfrom
Draft
RPC: Include index in getSignaturesForAddress response #1246#1248sdt03 wants to merge 3 commits intoanza-xyz:mainfrom
sdt03 wants to merge 3 commits intoanza-xyz:mainfrom
Conversation
|
BundleMonFiles updated (3)
Unchanged files (133)
Total files change +68B +0.02% Final result: ✅ View report in BundleMon website ➡️ |
Member
|
Thanks for this! We need to figure out when to align Kit to Agave 4.0 (and if we need a new branch etc), so I've put this as draft for now. But will get this merged once we figure out our approach! |
mcintyre94
added
the
do-not-close
Author
Thank you for reviewing this. Would it be possible to assign it back to me if any changes or follow ups are needed while you figure out the approach? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem [Refers to Issue #1246 ]
With anza-xyz/agave#9683, to be included with Agave v4.0, getSignaturesForAddress will include the block index of each transaction returned. Kit should also include this new field.
Summary of Changes