Add withCleanup function to @solana/plugin-core#1480
Merged
mcintyre94 merged 2 commits intomainfrom Mar 27, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: 20b3992 The changes in this PR will be included in the next version bump. This PR includes changesets to release 46 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
BundleMonFiles updated (4)
Unchanged files (138)
Total files change +929B +0.19% Final result: ✅ View report in BundleMon website ➡️ |
Contributor
|
Documentation Preview: https://kit-docs-omklur5iu-anza-tech.vercel.app |
lorisleiva
approved these changes
Mar 17, 2026
Member
lorisleiva
left a comment
lorisleiva
left a comment
There was a problem hiding this comment.
Very nice! Just a couple of nits. Is the idea that we only support sync dispose for now and if we need async support we can add withAsyncCleanup in the future?
mcintyre94
force-pushed
the
with-cleanup
branch
from
118634a to
f07d644
Compare
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
mcintyre94
force-pushed
the
with-cleanup
branch
3 times, most recently
from
a152bf6 to
8676a63
Compare
Adds a `withCleanup` function that wraps any client with a synchronous `Symbol.dispose` method, enabling the TC39 `using` declaration pattern. Note that only synchronous cleanup is supported for now — async teardown (`Symbol.asyncDispose`) is not yet handled. If the client already has a `Symbol.dispose`, the new cleanup is chained so both run when the client is disposed. Includes unit tests and a type test.
mcintyre94
force-pushed
the
with-cleanup
branch
from
8676a63 to
20b3992
Compare
Member
Author
|
We discussed offline, and decided to keep broadly this design. I've refactored this PR to use a This does add some state to the client object, which is maintained in a non-enumerable |
lorisleiva
approved these changes
Mar 27, 2026
Member
lorisleiva
left a comment
lorisleiva
left a comment
There was a problem hiding this comment.
Nice! The disposable stack API is great!
Contributor
|
🔎💬 Inkeep AI search and chat service is syncing content for source 'Solana Kit Docs' |
This was referenced Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
withCleanupfunction that extends any client with a synchronousSymbol.disposemethod, enabling the TC39usingdeclaration pattern. Note that only synchronous cleanup is supported for now — async teardown (Symbol.asyncDispose) is not yet handled. If the client already has aSymbol.dispose, the new cleanup is chained so both run when the client is disposed. Includes unit tests and a type test.