-
Notifications
You must be signed in to change notification settings - Fork 1
feature: add new endpoint to get latest wave buoy date #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, please also add test case to cover your change
| public enum FeatureId { | ||
| summary("summary"), | ||
| first_data_available("first_data_available"), | ||
| latest_date("latest_date"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will the data cover expand later? if not then better to have a very specific name for wave buoy, same for latest_date and timeseries
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, will update it.
| } | ||
|
|
||
| public byte[] getWaveBuoysLatestDate(){ | ||
| HttpHeaders headers = new HttpHeaders(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicated code, why not refactor it all to a @PostConstruct init function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay
utas-raymondng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, make sure you update your FE to the renamed api call
No description provided.