Skip to content

Make digraph creation case insensitive #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
neraath wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make digraph creation case insensitive #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d3b353
Helping the building of the Graph be case insensitive.
Apr 8, 2021
b0113b7
Ensuring projects in the digraph are compared in a case insensitive m…
Apr 8, 2021
f0e9d57
Adding one additional point that requires Case Insensitive comparison.
Apr 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Common/DotGraphUtilities/DotGraph.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public static class DotGraph
{
public static IDictionary<string, SortedSet<string>> LoadDependencyGraph(string targetFile)
{
IDictionary<string, SortedSet<string>> result = new SortedDictionary<string, SortedSet<string>>();
IDictionary<string, SortedSet<string>> result = new SortedDictionary<string, SortedSet<string>>(StringComparer.InvariantCultureIgnoreCase);

IEnumerable<string> validDigraphLines = ParseForValidDigraphLines(targetFile);

Expand Down
7 changes: 4 additions & 3 deletions MsBuildProjectReferenceDependencyGraph/MSBPRDependencyGraph.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

namespace MsBuildProjectReferenceDependencyGraph
{
using System;
using System.Collections.Concurrent;
using System.Collections.Generic;
using System.IO;
Expand All @@ -26,7 +27,7 @@ class MSBPRDependencyGraph
internal static Dictionary<string, IEnumerable<string>> ResolveProjectReferenceDependencies(IEnumerable<string> targetProjects)
{
Stack<string> unresolvedProjects = new Stack<string>();
Dictionary<string, IEnumerable<string>> resolvedProjects = new Dictionary<string, IEnumerable<string>>();
Dictionary<string, IEnumerable<string>> resolvedProjects = new Dictionary<string, IEnumerable<string>>(StringComparer.InvariantCultureIgnoreCase);

// Load up the initial projects to the stack
foreach (string targetProject in targetProjects.Distinct())
Expand Down Expand Up @@ -279,7 +280,7 @@ internal static Dictionary<string, IEnumerable<string>> ResolveAssemblyReference
);

// Convert this into the Dictionary
Dictionary<string, IEnumerable<string>> result = new Dictionary<string, IEnumerable<string>>();
Dictionary<string, IEnumerable<string>> result = new Dictionary<string, IEnumerable<string>>(StringComparer.InvariantCultureIgnoreCase);
foreach (KeyValuePair<string, IEnumerable<string>> kvp in resolvedAssemblyReferences)
{
result.Add(kvp.Key, kvp.Value);
Expand Down Expand Up @@ -307,7 +308,7 @@ internal static Dictionary<string, IEnumerable<string>> ResolvePackageReferenceD
);

// Convert this into the Dictionary
Dictionary<string, IEnumerable<string>> result = new Dictionary<string, IEnumerable<string>>();
Dictionary<string, IEnumerable<string>> result = new Dictionary<string, IEnumerable<string>>(StringComparer.InvariantCultureIgnoreCase);
foreach (KeyValuePair<string, IEnumerable<string>> kvp in resolvedPackageReferences)
{
result.Add(kvp.Key, kvp.Value);
Expand Down
3 changes: 2 additions & 1 deletion ProcessParallelAbility/ProcessParallelAbility/ParallelAbility.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

namespace ProcessParallelAbility
{
using System;
using System.Collections.Generic;
using System.Linq;

Expand Down Expand Up @@ -40,7 +41,7 @@ internal static IDictionary<int, List<string>> ConvertParallelTreeToLevels(IDict
/// <returns>A structure in which the Key is the project and the value is the depth within the given dependency tree.</returns>
internal static IDictionary<string, int> ResolveParallelTree(IDictionary<string, SortedSet<string>> dependencyTree)
{
IDictionary<string, int> parallelBuildTree = new Dictionary<string, int>();
IDictionary<string, int> parallelBuildTree = new Dictionary<string, int>(StringComparer.InvariantCultureIgnoreCase);

foreach (KeyValuePair<string, SortedSet<string>> dotGraphEntry in dependencyTree)
{
Expand Down