MP: rewrite iamclient#161
Open
MykolaSuperman wants to merge 5 commits intoaosedge:feature_unificationfrom
Open
MP: rewrite iamclient#161MykolaSuperman wants to merge 5 commits intoaosedge:feature_unificationfrom
MykolaSuperman wants to merge 5 commits intoaosedge:feature_unificationfrom
Conversation
Signed-off-by: Mykola Solianko <mykola_solianko@epam.com>
MykolaSuperman
force-pushed
the
rewrite_iamclient
branch
from
39b6103 to
a0b06dd
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature_unification #161 +/- ##
======================================================
Coverage ? 82.36%
======================================================
Files ? 325
Lines ? 30703
Branches ? 3198
======================================================
Hits ? 25287
Misses ? 5416
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
|
||
| add_subdirectory(app) | ||
| add_subdirectory(cmclient) | ||
| add_subdirectory(communication) |
Collaborator
There was a problem hiding this comment.
probably better leave removed.
mykola-kobets-epam
approved these changes
Feb 11, 2026
Collaborator
mykola-kobets-epam
left a comment
mykola-kobets-epam
left a comment
There was a problem hiding this comment.
Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>
al1img
reviewed
Feb 17, 2026
|
|
||
| Error IAMClient::Start() | ||
| { | ||
| LOG_DBG() << "Start IAM client"; |
src/mp/iamclient/iamclient.cpp
Outdated
|
|
||
| Error IAMClient::SendMessages(std::vector<uint8_t> messages) | ||
| { | ||
| LOG_DBG() << "Sending messages"; |
src/mp/iamclient/iamclient.cpp
Outdated
|
|
||
| RetWithError<std::vector<uint8_t>> IAMClient::ReceiveMessages() | ||
| { | ||
| LOG_DBG() << "Receiving messages"; |
src/mp/iamclient/iamclient.cpp
Outdated
| { | ||
| std::vector<uint8_t> message(msg.ByteSizeLong()); | ||
|
|
||
| LOG_DBG() << "Received message: msg=" << msg.DebugString().c_str(); |
src/mp/iamclient/iamclient.cpp
Outdated
| LOG_DBG() << "Received message: msg=" << msg.DebugString().c_str(); | ||
|
|
||
| if (!msg.SerializeToArray(message.data(), message.size())) { | ||
| LOG_ERR() << "Failed to serialize message"; |
Collaborator
There was a problem hiding this comment.
You can return error with message instead of displaying err log
src/mp/iamclient/iamclient.cpp
Outdated
| while (mStarted) { | ||
| auto [msg, err] = mOutgoingMsgChannel.Receive(); | ||
| if (!err.IsNone()) { | ||
| LOG_ERR() << "Failed to receive message: error=" << err; |
src/mp/iamclient/iamclient.cpp
Outdated
| LOG_DBG() << "Sending message: msg=" << outgoingMsg.DebugString().c_str(); | ||
|
|
||
| if (auto sendErr = SendMessage(outgoingMsg); !sendErr.IsNone()) { | ||
| LOG_ERR() << "Failed to send message: error=" << sendErr; |
added 4 commits
February 17, 2026 12:38
Signed-off-by: Mykola Solianko <mykola_solianko@epam.com>
Signed-off-by: Mykola Solianko <mykola_solianko@epam.com>
Signed-off-by: Mykola Solianko <mykola_solianko@epam.com>
Signed-off-by: Mykola Solianko <mykola_solianko@epam.com>
MykolaSuperman
force-pushed
the
rewrite_iamclient
branch
from
a0b06dd to
6c566a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.