Removed ECAdmin, created 3 new KeywordExecutable commands #6104
Conversation
test/src/main/java/org/apache/accumulo/test/start/KeywordStartIT.java
Outdated
Show resolved
Hide resolved
ctubbsii
left a comment
ctubbsii
left a comment
There was a problem hiding this comment.
I think "ec-admin" definitely needed a rename to be more convenient. I'm not too sure if it technically needed to be split into separate granular commands. We have talked about consolidating other utilities, like the ones for ZK/property management.
It's possible one balance is to use the group name as part of the command line structure, so instead of executing bin/accumulo ec-admin cancel or bin/accumulo cancel-compaction, we have a compaction group, and the command line would look like bin/accumulo compaction cancel. We could automatically prefix the group onto commands, like the reverse of what git does (git svn executes the git-svn command), so one would execute bin/accumulo compaction-cancel (bin/accumulo <GROUP>-<command>).
There seems to be many possible options, but it would be nice to have a good convention that helps us organize the individual commands, but doesn't bloat the usage, or overwhelm the user with subcommands at the top level in a flat structure of all commands. We should have some mechanism that allows subcommands to be grouped more logically so as not to overwhelm.
| CompactionCoordinatorService.Client coordinatorClient; | ||
| try { | ||
| coordinatorClient = ThriftUtil.getClient(ThriftClientTypes.COORDINATOR, address, context); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
This exception catch block should be more narrow.
|
|
||
| @Override | ||
| public String keyword() { | ||
| return "cancel-compaction"; |
There was a problem hiding this comment.
It would probably be good to have compaction related stuff together, either in the same group, like one named "compaction" or having a common prefix, like "compaction-cancel" instead of "cancel-compaction".
3 participants
Closes #6087