[#2275] Drop redundant sequence generator monitor in RegionBroker - #2283
Open
mattrpav wants to merge 1 commit into
Open
[#2275] Drop redundant sequence generator monitor in RegionBroker#2283mattrpav wants to merge 1 commit into
mattrpav wants to merge 1 commit into
Conversation
cshannon
approved these changes
Aug 4, 2026
cshannon
left a comment
cshannon
left a comment
Contributor
There was a problem hiding this comment.
I have no idea why this is protected by synchronized, it's already using the atomic sequencer as you pointed out so i don't see any reason to not do this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LongSequenceGenerator is private final on RegionBroker and is already thread-safe. The synchronized is redundant.