Fix null pointer handling in array iteration #2313
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ProjectMutilation
force-pushed
the
utils-adt-avoid-potential-null-deref
branch
from
e68f7bb to
535e5ea
Compare
Previously, when iterating through an agtype container, the code would access `elem->val` even when `elem` was null. This adds a null check to set the result type to AGTV_NULL when the element is null, preventing a potential segmentation fault. Fixes: 4274f10 ("Added the toStringList() function (apache#1084)") Found by PostgresPro. Signed-off-by: Maksim Korotkov <m.korotkov@postgrespro.ru>
ProjectMutilation
force-pushed
the
utils-adt-avoid-potential-null-deref
branch
from
535e5ea to
57bf50d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when iterating through an agtype container, the code would access
elem->valeven whenelemwas null.This adds a null check to set the result type to AGTV_NULL when the element is null, preventing a potential segmentation fault.
Fixes: 4274f10 ("Added the toStringList() function (#1084)")
Found by PostgresPro.