bugfix: Enforce and document context injection into custom callbacks#62649
Merged
ferruzzi merged 5 commits intoapache:mainfrom Mar 5, 2026
Merged
Conversation
Contributor
Author
|
followup to #61153 |
jason810496
approved these changes
Mar 2, 2026
vincbeck
approved these changes
Mar 2, 2026
o-nikolas
reviewed
Mar 2, 2026
o-nikolas
approved these changes
Mar 4, 2026
1Ninad
pushed a commit
to 1Ninad/airflow
that referenced
this pull request
Mar 6, 2026
…pache#62649) * Enforce and document context injection into custom callbacks
dominikhei
pushed a commit
to dominikhei/airflow
that referenced
this pull request
Mar 11, 2026
…pache#62649) * Enforce and document context injection into custom callbacks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a bug while manual testing deadline alerts. We are now injecting
contextinto custom callbacks, but if the user didn't addcontextor**kwargsto their custom callback, it will fail with an unexpected parameter exception. We can either document that all custom callbacks need that, or we can add guardrails socontextis only provided if it is supported. I figured the latter was more robust and safer. New code filters parameters going into any custom callback to only provide parameters it expects.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rstor{issue_number}.significant.rst, in airflow-core/newsfragments.