Skip to content

Only update RTIF for terminal task states #63719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
amoghrajesh wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −5
Draft

Only update RTIF for terminal task states #63719

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions task-sdk/src/airflow/sdk/execution_time/task_runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1761,11 +1761,19 @@ def finalize(

if getattr(ti.task, "overwrite_rtif_after_execution", False):
log.debug("Overwriting Rendered template fields.")
if ti.task.template_fields:
try:
SUPERVISOR_COMMS.send(SetRenderedFields(rendered_fields=_serialize_rendered_fields(ti.task)))
except Exception:
log.exception("Failed to set rendered fields during finalization", ti=ti, task=ti.task)
# Only update RTIF for terminal states. RTIF table doesn't have try_number column,
# so intermediate states (UP_FOR_RETRY, UP_FOR_RESCHEDULE, DEFERRED) would just
# overwrite each other. We only store the terminal state attempt's rendered fields.
if state in (TaskInstanceState.SUCCESS, TaskInstanceState.FAILED, TaskInstanceState.SKIPPED):
if ti.task.template_fields:
try:
SUPERVISOR_COMMS.send(SetRenderedFields(rendered_fields=_serialize_rendered_fields(ti.task)))
except Exception:
log.exception(
"Failed to set rendered fields during finalization",
task_id=ti.task_id,
dag_id=ti.dag_id,
)

log.debug("Running finalizers", ti=ti)
if state == TaskInstanceState.SUCCESS:
Expand Down
Loading