Fix PoolBar links using wrong query params for task instances page#64182
Open
Karthikeya1500 wants to merge 8 commits intoapache:mainfrom
Open
Fix PoolBar links using wrong query params for task instances page#64182Karthikeya1500 wants to merge 8 commits intoapache:mainfrom
Karthikeya1500 wants to merge 8 commits intoapache:mainfrom
Conversation
The PoolBar component links to the task instances page using
SearchParamsKeys.STATE ('state') and SearchParamsKeys.POOL ('pool'),
but the TaskInstances page reads filters from SearchParamsKeys.TASK_STATE
('task_state') and SearchParamsKeys.POOL_NAME_PATTERN ('pool_name_pattern').
This mismatch causes clicking a pool slot segment (running, queued, etc.)
to navigate to the task instances page without any filters being applied,
showing all task instances instead of those filtered by the clicked state
and pool.
Fix by using the correct search parameter keys (TASK_STATE and
POOL_NAME_PATTERN) and slot.slotType instead of slot.color for the
state filter value.
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
bbovenzi
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking on a pool slot segment (e.g. running or queued) in the Pools page navigates to
/task_instancesbut the state and pool filters don't get applied. The task instances page shows unfiltered results instead.The root cause is that
PoolBar.tsxusesSearchParamsKeys.STATE(state) andSearchParamsKeys.POOL(pool), but theTaskInstancespage actually reads fromSearchParamsKeys.TASK_STATE(task_state) andSearchParamsKeys.POOL_NAME_PATTERN(pool_name_pattern). The parameter name mismatch causes the filters to be silently ignored.I also noticed
slot.colorwas being used as the state value instead ofslot.slotType. They happen to match for non-open slots right now, butslotTypeis the semantically correct value to pass as a task instance state filter.