Skip to content

fix: use Dag form when materializing asset#64211

Open
Lee-W wants to merge 6 commits intoapache:mainfrom
astronomer:use-Dag-form-when-triggering-asset-materialization
Open

fix: use Dag form when materializing asset#64211
Lee-W wants to merge 6 commits intoapache:mainfrom
astronomer:use-Dag-form-when-triggering-asset-materialization

Conversation

@Lee-W
Copy link
Member

@Lee-W Lee-W commented Mar 25, 2026

Why

Closes: #63807

What

Use Dag from when materializing the asset
image
image


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Mar 25, 2026
@Lee-W Lee-W added this to the Airflow 3.2.0 milestone Mar 25, 2026
Copy link
Contributor

@bbovenzi bbovenzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

But I am wondering if creating the concept of "materialize" has added unnecessary overhead. Now, we can do all of this with the existing trigger dag post endpoint except for having a different run type.

@Lee-W Lee-W force-pushed the use-Dag-form-when-triggering-asset-materialization branch from 4c3b2f7 to abaac1a Compare March 26, 2026 10:55
@Lee-W Lee-W force-pushed the use-Dag-form-when-triggering-asset-materialization branch 2 times, most recently from 3f63ffd to d2a9c8c Compare March 26, 2026 11:55
@Lee-W Lee-W requested a review from bbovenzi March 26, 2026 12:02
@Lee-W Lee-W force-pushed the use-Dag-form-when-triggering-asset-materialization branch from d2a9c8c to 52679e8 Compare March 27, 2026 01:49
Copy link
Member

@jason810496 jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall on the API side.

class MaterializeAssetBody(TriggerDAGRunPostBody):
"""Materialize asset request."""

logical_date: AwareDatetime | None = None
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already had logical_date field for TriggerDAGRunPostBody, do we still need to add it again here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to set the default as None

@Lee-W Lee-W force-pushed the use-Dag-form-when-triggering-asset-materialization branch from 52679e8 to 29a31dc Compare March 27, 2026 07:31
@Lee-W Lee-W force-pushed the use-Dag-form-when-triggering-asset-materialization branch from 29a31dc to 304a540 Compare March 27, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No option to provide partition key while materialising an asset

3 participants