Fix: handle cross-event-loop RuntimeError in ExecutionAPISecretsBackend#64238
Open
abhijeets25012-tech wants to merge 1 commit intoapache:mainfrom
Open
Conversation
abhijeets25012-tech
requested review from
amoghrajesh,
ashb and
kaxil
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened
In triggerer context,
ExecutionAPISecretsBackend.get_connection()may fail whenTriggerCommsDecoder.send()raises a RuntimeError with message:"Future attached to a different loop"
Currently, only the AsyncToSync RuntimeError is handled. Other RuntimeError variants
fall through and return None, causing the connection lookup to silently fail.
This leads to incorrect behavior in deferrable operators (e.g. AWS hooks),
where the connection appears missing and falls back to default credentials.
What is fixed
Extended RuntimeError handling to also cover the "attached to a different loop"
case and fallback to async connection retrieval using
greenback.await_.Why this is safe
return None)Reproduction
Deferrable AWS hooks (e.g. S3KeySensor) in triggerer context fail to resolve
connections and log "Unable to find AWS Connection ID" due to this issue.