Skip to content

Refactor latest DagRun load options for consistency #67911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
henry3260 wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −26
Open

Refactor latest DagRun load options for consistency #67911

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 14 additions & 26 deletions airflow-core/src/airflow/dag_processing/collection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,18 @@ def _create_orm_dags(
yield orm_dag


def _build_latest_run_load_options() -> Any:
return load_only(
DagRun.dag_id,
DagRun.logical_date,
DagRun.run_after,
DagRun.data_interval_start,
DagRun.data_interval_end,
DagRun.partition_key,
DagRun.partition_date,
)


def _get_latest_runs_stmt(dag_id: str) -> Select:
"""Build a select statement to retrieve the last automated run for each dag."""
max_logical_date = (
Expand All @@ -125,17 +137,7 @@ def _get_latest_runs_stmt(dag_id: str) -> Select:
DagRun.dag_id == dag_id,
DagRun.logical_date == max_logical_date,
)
.options(
load_only(
DagRun.dag_id,
DagRun.logical_date,
DagRun.run_after,
DagRun.data_interval_start,
DagRun.data_interval_end,
DagRun.partition_key,
DagRun.partition_date,
)
)
.options(_build_latest_run_load_options())
)


Expand All @@ -161,21 +163,7 @@ def _get_latest_runs_stmt_partitioned(dag_id: str) -> Select:
.limit(1)
.scalar_subquery()
)
return (
select(DagRun)
.where(DagRun.id == latest_run_id)
.options(
load_only(
DagRun.dag_id,
DagRun.logical_date,
DagRun.run_after,
DagRun.data_interval_start,
DagRun.data_interval_end,
DagRun.partition_key,
DagRun.partition_date,
)
)
)
return select(DagRun).where(DagRun.id == latest_run_id).options(_build_latest_run_load_options())


class _RunInfo(NamedTuple):
Expand Down
Loading