Add shared_stream_cohort_grace_period to reduce missed events on triggerer restart#68888
Merged
Conversation
Lee-W
changed the title
Lee-W
force-pushed
the
shared-stream-grace
branch
4 times, most recently
from
01d1b8e to
34f7d24
Compare
1 task
Member
Author
…gerer restart On triggerer restart, triggers sharing the same key re-subscribe concurrently. Without a grace period the first to arrive creates a fresh group and polling starts immediately; triggers that re-subscribe later miss events committed before they join. Setting [triggerer] shared_stream_cohort_grace_period to a positive value delays the start of polling after a group is created, giving the initial cohort a window to subscribe before any event is broadcast. Default is 0.0 (no delay, backward-compatible).
Lee-W
force-pushed
the
shared-stream-grace
branch
from
34f7d24 to
e1bd344
Compare
jason810496
approved these changes
Jun 24, 2026
Contributor
|
Hi maintainer, this PR was merged without a milestone set.
|
Contributor
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
github-actions Bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 24, 2026
…ents on triggerer restart (apache#68888) (cherry picked from commit 3d2a635) Co-authored-by: Wei Lee <weilee.rx@gmail.com>
aws-airflow-bot
pushed a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Jun 24, 2026
…ents on triggerer restart (apache#68888) (cherry picked from commit 3d2a635) Co-authored-by: Wei Lee <weilee.rx@gmail.com>
cetingokhan
pushed a commit
to cetingokhan/airflow
that referenced
this pull request
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On triggerer restart, triggers that share the same shared-stream key re-subscribe concurrently. The first to arrive creates a fresh group and polling starts immediately, so triggers that join a moment later miss events committed before they subscribed. This adds an opt-in
[triggerer] shared_stream_cohort_grace_periodthat delays the start of polling, giving the initial cohort a window to subscribe before any event is broadcast.Why
What
[triggerer] shared_stream_cohort_grace_periodconfig (float seconds, default0.0= no delay, backward-compatible).SharedStreamManager._poll()sleeps for the grace period before opening the stream when the value is> 0.Was generative AI tooling used to co-author this PR?
Generated-by: [Claude] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.