[Serialization] Fix: Serialize DagParam like a normal Param.#68901
Open
Desdroid wants to merge 1 commit into
Open
[Serialization] Fix: Serialize DagParam like a normal Param.#68901Desdroid wants to merge 1 commit into
Desdroid wants to merge 1 commit into
Conversation
Contributor
Author
|
@ephraimbuddy @wjddn279 Since you were working on serialization in #63871 - what do you think of this fix I propose here? Does this make sense or is it wrong and some change is needed in |
yuseok89
reviewed
Jun 24, 2026
Comment on lines
+582
to
+585
| elif isinstance(var, DagParam): | ||
| return cls._encode( | ||
| cls._serialize_param(Param(default=var._default, source="dag")), type_=DAT.PARAM | ||
| ) |
Contributor
There was a problem hiding this comment.
Have you tested this? Looking at the code, it seems only _default is stored and _name is dropped, and since DagParam resolves at runtime via dag_run.conf[self._name], I think this could be a problem. Or am I misreading the flow?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we use a DagParam as a kwarg to
partial()of a dynamically mapped task, the DagParam will be serialized with its memory address. This leads to a DAG version inflation, as the memory address is not stable.This is a simple repro:
This PR fixes this issue by serializing the DagParam as a normal Param. This behavior matches the serialization that using the
DagParamas a normal arg does (like in thedotask - it ends up being serialized as aParam).Note: I am not 100% sure that this is the correct fix as I'm not super deep in the DAG serialization code, but it seems to work.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.